buildRustPackage: simplify the cargoDeps specification and remove dead code#384345
Merged
ShamrockLee merged 3 commits intoNixOS:masterfrom Feb 25, 2025
Merged
buildRustPackage: simplify the cargoDeps specification and remove dead code#384345ShamrockLee merged 3 commits intoNixOS:masterfrom
ShamrockLee merged 3 commits intoNixOS:masterfrom
Conversation
cargoDeps gets shadowed in the implementation whether or not it is excluded.
github-actions
bot
added
6.topic: rust
Contributor
Author
|
Contributor
|
Typo in the last commit, |
ShamrockLee
force-pushed
the
build-rust-package-misc
branch
from
edf8358 to
89c72ca
Compare
Contributor
Author
@zowoq Addressed. Thank you for reviewing! |
zowoq
approved these changes
Feb 24, 2025
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-384345-to-release-24.11 origin/release-24.11
cd .worktree/backport-384345-to-release-24.11
git switch --create backport-384345-to-release-24.11
git cherry-pick -x ef987dba19b88e589718eb99c78a5e59e4e85967 d84d1eeb22a19def830ffa180fc2d004c3c69eb1 89c72ca6a20bde0b6acaebaa323eee7f1eb0ea14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These chore clean-ups aim to simplify the
buildRustPackagecode and create a cleaner ground for future overriding fixes and potential interface changes.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.